Opened 5 months ago

Closed 4 months ago

Last modified 3 months ago

#5460 closed change (fixed)

Add support to show a notification based on the locale of the user

Reported by: wspee Assignee: wspee
Priority: P2 Milestone:
Module: Core Keywords:
Cc: trev, sebastian Blocked By:
Blocking: #5458 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29501607/

Description (last modified by wspee)

Background

For our upcoming cross promotion campaign we want to be able to show notifications to users that use a certain locale.

What to change

Add support to show a notification only if the user uses a certain locale, as specified in #5458.

Change History (9)

comment:1 Changed 5 months ago by wspee

  • Description modified (diff)

comment:2 Changed 5 months ago by wspee

  • Cc snoack trev added
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 5 months ago by wspee

  • Blocking 5458 added

comment:4 Changed 5 months ago by sebastian

  • Cc sebastian added; snoack removed

comment:5 Changed 4 months ago by wspee

  • Review URL(s) modified (diff)

comment:7 Changed 4 months ago by wspee

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed 4 months ago by trev

  • Priority changed from Unknown to P2
  • Ready set

comment:9 Changed 3 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. This works in Chrome. Unable to test in Opera at the moment due to #5759.

ABP 1.13.3.1838
Chrome 49 / 61 / Windows 7

Note: See TracTickets for help on using tickets.