Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#547 closed change (fixed)

Refactor proxy registration

Reported by: fhd Assignee: rjeschke
Priority: P2 Milestone: Adblock-Plus-for-Android-1.3
Module: Adblock-Plus-for-Android Keywords:
Cc: rjeschke, trev Blocked By:
Blocking: #135 Platform: Android
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/4705284891082752/

Description

Background

The proxy registration logic is currently very hard to follow, and harder to add to.

What to change

Make the code more flexible and more maintainable. We should discuss the approach here.

Change History (9)

comment:1 Changed 5 years ago by fhd

  • Blocking 135 added

comment:2 Changed 5 years ago by fhd

  • Owner set to rjeschke
  • Platform set to Android
  • Priority changed from P3 to P2

comment:3 Changed 5 years ago by rjeschke

  • Blocking 1214 added

comment:4 Changed 5 years ago by rjeschke

  • Blocking 1214 removed
  • Review URL(s) modified (diff)

comment:5 Changed 5 years ago by rjeschke

First part of review in progress.

comment:6 Changed 5 years ago by trev

  • Cc trev added

This was pushed: https://hg.adblockplus.org/adblockplusandroid/rev/376a06af35f9

@rjeschke: is more coming or is this issue fixed?

comment:7 Changed 5 years ago by rjeschke

@trev this here is fixed, closing it now.

comment:8 Changed 5 years ago by rjeschke

  • Resolution set to fixed
  • Status changed from new to closed

comment:9 Changed 5 years ago by trev

  • Milestone set to Adblock-Plus-for-Android-1.3
Note: See TracTickets for help on using tickets.