Opened 4 months ago

Closed 3 months ago

Last modified 3 months ago

#5470 closed defect (fixed)

Clipped text 'Block ads on this site' in dropdown menu

Reported by: diegocarloslima Assignee: diegocarloslima
Priority: P3 Milestone: Adblock-Browser-for-Android-1.2.0
Module: Adblock-Browser-for-Android Keywords:
Cc: Shikitita Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29505613/

Description (last modified by diegocarloslima)

Environment

Samsung S6
abb-merge-45-0-2-build-2-signed-zipaligned.apk

How to reproduce

  1. Change device language to Français or change it inside the browser's language settings.
  2. Click on the 3 vertical dots to show the dropdown menu

Observed behaviour

The text is shown clipped as 'Bloquer les pu...tés de ce site' (See attachment).

Expected behaviour

The text should be displayed fully as 'Bloquer les publicités de ce site'. We have agreed through a discussion on IRC, that we should show the dropdown menu items in 2 lines maximum and if it needs to be clipped, it will be in the end (See option #3 in the attached screenshot).

Attachments (2)

Screenshot_20170728-164057.png (264.9 KB) - added by diegocarloslima 4 months ago.
Screenshot_20170801-111306.png (172.9 KB) - added by diegocarloslima 4 months ago.
Dropdown menu text options

Download all attachments as: .zip

Change History (10)

Changed 4 months ago by diegocarloslima

Changed 4 months ago by diegocarloslima

Dropdown menu text options

comment:1 Changed 4 months ago by diegocarloslima

  • Description modified (diff)

comment:2 Changed 4 months ago by diegocarloslima

  • Component changed from Unknown to Adblock-Browser-for-Android

comment:3 Changed 4 months ago by diegocarloslima

  • Description modified (diff)

comment:4 Changed 4 months ago by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 3 months ago by abpbot

comment:6 Changed 3 months ago by diegocarloslima

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed 3 months ago by abpbot

comment:8 Changed 3 months ago by Shikitita

  • Verified working set
Note: See TracTickets for help on using tickets.