Opened on 08/07/2017 at 12:10:22 PM

Closed on 08/22/2017 at 02:23:42 PM

#5473 closed change (fixed)

Update to use libadblockplus revision b4d6e55f2116

Reported by: sergz Assignee:
Priority: Unknown Milestone:
Module: Libadblockplus-Android Keywords:
Cc: asmirnov Blocked By:
Blocking: #5266 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):



Beside other things the new version of libadblockplus uses android NDK 12b and there are almost no changes in the public API of libadblockplus until this revision.

The list of changes imported by this is:

b4d6e55f2116Noissue - don't throw a pointer to an exception in C++Sergei Zabolotskikh
0f144e401672Noissue - move anonymous namespace from header to cpp fileSergei Zabolotskikh
16ea1ae3347dNoissue - synchronize usage of struct and classSergei Zabolotskikh
35e4ccd3b140Noissue - remove unnecessary including of v8.hSergei Zabolotskikh
094e2850704bNoissue - move host detecting script into libadblockplus repoSergei Zabolotskikh
193cb0a8b53eNoissue - remove obsolete part of a commentSergei Zabolotskikh
451ff2c10f78Noissue - fix headers in order to compile on MS WindowsSergei Zabolotskikh
ebd2573db477Noissue - Use buffer for FileSystem IOHubert Figuière
4932fd217b7dNoissue - Fix some execution order issues in the prefs initialisationHubert Figuière
dd95ab67d425Noissue - fix typo "dowload" to "download" (n is absent)Sergei Zabolotskikh

What to change

Prepare and update libadblockplus-binaries dependency to libadblockplus hg:b4d6e55f2116 revision as well as adapt the code.

Attachments (0)

Change History (6)

comment:1 Changed on 08/07/2017 at 12:11:02 PM by sergz

  • Review URL(s) modified (diff)

comment:2 Changed on 08/07/2017 at 12:49:46 PM by asmirnov

  • Review URL(s) modified (diff)

comment:3 Changed on 08/08/2017 at 05:13:33 AM by abpbot

A commit referencing this issue has landed:
Issue 5473 - Update to use libadblockplus revision b4d6e55f2116

comment:4 Changed on 08/08/2017 at 11:44:17 AM by sergz

  • Blocking 5266 added

comment:5 Changed on 08/09/2017 at 06:55:35 AM by abpbot

A commit referencing this issue has landed:
Issue 5473 - update to libadblockplus revision b4d6e55f2116

comment:6 Changed on 08/22/2017 at 02:23:42 PM by sergz

  • Resolution set to fixed
  • Status changed from new to closed

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Note: See TracTickets for help on using tickets.