#5477 closed defect (fixed)

Buildtool doesn't import localization string placeholders on build

Reported by: saroyanm Assignee: tlucas
Priority: P2 Milestone:
Module: Automation Keywords:
Cc: sebastian, greiner, kzar, tlucas Blocked By:
Blocking: #5158 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29517660/

Description (last modified by tlucas)

Environment

As defined here

How to reproduce

  1. Clone adblockplus repository
  2. Add line below into metadate.chrome to the [import_locales] section:
    adblockplusui/locale/*/new-options.json = =*
    
  1. Run ./build.py -t chrome devenv
  2. Import generated extension into chrome browser
  3. Observe

Observed behaviour

Current error is being thrown:

Variable $domain$ used but not defined.

Expected behaviour

No error is thrown and corresponding placeholder is being imported into generated locale/*/messages.json file.

What to test

  • Importing gecko-locales still as expected
  • Escaping string names (IDs) as expected (see git-commit fc0b3313 / 3f614288 )

Change History (9)

comment:1 Changed 20 months ago by saroyanm

  • Cc sebastian greiner kzar added

So far only this issue is noticed after testing new options page in the production environment.

If you guys can check this out, I will highly appreciate that.

Last edited 20 months ago by saroyanm (previous) (diff)

comment:2 Changed 20 months ago by saroyanm

  • Summary changed from Buildtool doesn't import placeholders to Buildtool doesn't import localization string placeholders on build

comment:3 Changed 20 months ago by tlucas

  • Cc tlucas added

comment:4 Changed 19 months ago by sebastian

  • Priority changed from Unknown to P2
  • Ready set

comment:5 Changed 19 months ago by tlucas

  • Owner set to tlucas

comment:6 Changed 19 months ago by tlucas

  • Description modified (diff)

comment:7 Changed 19 months ago by tlucas

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:8 Changed 19 months ago by abpbot

A commit referencing this issue has landed:
Issue 5477 - Import everything from imported locales

comment:9 Changed 19 months ago by tlucas

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.