Opened 2 years ago

Closed 2 years ago

#5480 closed change (fixed)

Add "watch" task to website-defaults gulpfile

Reported by: ire Assignee: ire
Priority: P3 Milestone:
Module: Websites Keywords: goodfirstbug
Cc: juliandoucette Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29529760

Description

Background

The website-defaults gulpfile has one task, scss, which compiles SCSS to CSS. When the gulp command is run, it runs this task once and ends.

What to change

  1. Add a watch task to watch all .scss files and automatically run the scss task:
gulp.task("watch", function ()
{
  gulp.watch("scss/**/*.scss", ["scss"]);
});
  1. Add the watch task to the default gulp task:
gulp.task("default", ["scss", "watch"]);

Change History (4)

comment:1 Changed 2 years ago by ire

  • Owner set to ire
  • Ready set

comment:2 Changed 2 years ago by ire

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5480 - Add "watch" task to website-defaults gulpfile

comment:4 Changed 2 years ago by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.