Opened 2 years ago

Closed 3 weeks ago

#5483 closed change (rejected)

Complete test-coverage for Build-and-Release-Tools

Reported by: tlucas Assignee:
Priority: P3 Milestone:
Module: Automation Keywords:
Cc: sebastian, kzar, kvas Blocked By:
Blocking: #5484 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by tlucas)

Background

With python2.x loosing support sometime in 2020, we want to have a decent test-coverage of the modules currently running on python2.x, before switching to python3 compatibility.

What to change

Provide tests for publicly used functionalities in the Build-and-Release-tools, which are not yet covered by #5383 and #4028, namely:

  • the commands in build.py
  • ensure_dependencies.py
  • xarfile.py

Change History (10)

comment:1 Changed 2 years ago by tlucas

  • Blocking 5484 added

comment:2 Changed 2 years ago by tlucas

  • Description modified (diff)

comment:3 Changed 2 years ago by kzar

  • Priority changed from Unknown to P3
  • Ready set

comment:4 Changed 2 years ago by tlucas

  • Owner set to tlucas

comment:5 Changed 2 years ago by kzar

  • Summary changed from Complete test-coverade for Build-and-Release-Tools to Complete test-coverage for Build-and-Release-Tools

comment:6 follow-up: Changed 2 years ago by sebastian

More importantly than testing the internal APIs of buildtools, we should test the build commands.

comment:7 in reply to: ↑ 6 Changed 2 years ago by tlucas

Replying to sebastian:

More importantly than testing the internal APIs of buildtools, we should test the build commands.

I agree - i will add this to the implementation as well.

comment:8 Changed 2 years ago by tlucas

  • Description modified (diff)

Changed the description in order to adhere to what was discussed in IRC

Last edited 2 years ago by tlucas (previous) (diff)

comment:9 Changed 2 years ago by tlucas

  • Owner tlucas deleted

Reset assignee: i'm currently not working on this

Last edited 2 years ago by tlucas (previous) (diff)

comment:10 Changed 3 weeks ago by sebastian

  • Resolution set to rejected
  • Status changed from new to closed

Rejecting this issue now as buildtools is in maintenance mode and will eventually be discontinued.

Note: See TracTickets for help on using tickets.