Opened 21 months ago

Last modified 3 weeks ago

#5499 reviewing change

Add tests for websocket and webrtc filter options

Reported by: sergz Assignee:
Priority: P4 Milestone:
Module: Websites Keywords:
Cc: fhd, ubernitt Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://gitlab.com/eyeo/adblockplus/testpages.adblockplus.org/merge_requests/11

Description

Background

#5475 introduces these new filter options which are now supported by adblockpluscore, therefore maybe some existing tests should be adapted as well as new tests for these types should be created.

What to do

Check existing tests and add new tests.

Change History (9)

comment:2 Changed 21 months ago by sergz

  • Blocking 5475 removed

comment:3 Changed 21 months ago by sergz

  • Blocked By 5475 added

comment:4 Changed 6 weeks ago by ubernitt

Links to DP-95 in the DP Team Jira board

comment:5 follow-up: Changed 6 weeks ago by Ross

Does this ticket refer to adding to the unit tests in adblockpluscore/adblockpluschrome or to the test pages? I'm assuming the first by this tickets age.

comment:6 in reply to: ↑ 5 Changed 5 weeks ago by ubernitt

Replying to Ross:

Does this ticket refer to adding to the unit tests in adblockpluscore/adblockpluschrome or to the test pages? I'm assuming the first by this tickets age.

Sorry for not seeing your question :(! No! At least, what we as the DP team care for, It's all about the test pages.

comment:7 Changed 5 weeks ago by ubernitt

  • Cc ubernitt added

comment:8 Changed 3 weeks ago by Ross

  • Blocked By 5475 removed
  • Component changed from Libadblockplus to Websites
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:9 Changed 3 weeks ago by abpbot

A commit referencing this issue has landed:
Issue 5499 - Fix the WebRTC test page

Note: See TracTickets for help on using tickets.