Opened 3 years ago

Closed 3 years ago

#5506 closed change (fixed)

Fix Notification test

Reported by: sergz Assignee: hfiguiere
Priority: P4 Milestone:
Module: Libadblockplus Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29525558
https://codereview.adblockplus.org/29539858/

Description

Background

Currently we have a disabled by #ifdef notification test because there is no way to inject some hard coded values in notification.js. This test often gets obsolete and not compilable, so it should have DISABLED_ prefix and be always compilable.

In addition, please consider a way to actually inject the required values.

Change History (7)

comment:1 Changed 3 years ago by hfiguiere

  • Owner set to hfiguiere
  • Review URL(s) modified (diff)

comment:2 Changed 3 years ago by hfiguiere

  • Status changed from new to reviewing

comment:3 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 5506 - Fix notification test

comment:4 Changed 3 years ago by hfiguiere

Currently the test is disabled, so it gets compiled. Next step is to fix it.

Last edited 3 years ago by hfiguiere (previous) (diff)

comment:5 Changed 3 years ago by hfiguiere

  • Review URL(s) modified (diff)

comment:6 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 5506 - Make the notification test work.

comment:7 Changed 3 years ago by hfiguiere

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.