Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#5507 closed change (fixed)

Download only translated files from Crowdin

Reported by: diegocarloslima Assignee: jwangenheim
Priority: P4 Milestone: Adblock-Browser-for-Android-1.3.0
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29516560/

Description

Background

Currently, we use our translations.py script to fetch all translations files from Crowdin. The issue is that it also fetches some locales that haven't been translated yet (e.g. Armenian , hy-AM)

What to change

See if its possible to only fetch the files that have at least something translated

Attachments (1)

Screenshot_20171012-054153.png (96.5 KB) - added by traynard 2 years ago.
English (UK) Search Engine list

Download all attachments as: .zip

Change History (9)

comment:1 Changed 2 years ago by jwangenheim

  • Owner set to jwangenheim

comment:2 Changed 2 years ago by jwangenheim

It is possible to check the translation progress with the crowdin API, but we can either fetch the translations for ONE or ALL languages.

I will extend translations.py with a method that returns a dictionary of all locales with their translation_progress and subsequently ignores the languages that haven't been translated yet.

Last edited 2 years ago by jwangenheim (previous) (diff)

comment:3 Changed 2 years ago by jwangenheim

  • Review URL(s) modified (diff)

comment:4 Changed 2 years ago by jwangenheim

  • Status changed from new to reviewing

comment:5 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5507 - Download only translated files from Crowdin

comment:6 Changed 2 years ago by jwangenheim

  • Milestone set to Adblock-Browser-for-Android-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Changed 2 years ago by traynard

English (UK) Search Engine list

comment:7 Changed 2 years ago by traynard

oops attached above screenshot to the wrong ticket. Please ignore

comment:8 Changed 2 years ago by traynard

  • Verified working set
Note: See TracTickets for help on using tickets.