#5508 closed change (fixed)

Implement virtual file system in tests.

Reported by: sergz Assignee: sergz
Priority: P2 Milestone:
Module: Libadblockplus Keywords:
Cc: Blocked By: #5475
Blocking: #5183 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29535562/

Description

Background

After #5475 we can provide with a very simple implementation of a virtual file system, therefore get rid of using of a default file system in tests.

What to change

Implement IFileSystem which stores files in the memory and use it everywhere in tests instead of default implementation of file system.

Change History (4)

comment:1 Changed 21 months ago by sergz

  • Blocking 5183 added
  • Owner set to sergz
  • Priority changed from P5 to P2

The changes related to this issue simplify the process of switching from std::shared_ptr to std::unique_ptr of IFileSystem held by Platform.

comment:2 Changed 21 months ago by sergz

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 21 months ago by abpbot

A commit referencing this issue has landed:
Issue 5508 - implement InMemoryFS for tests

comment:4 Changed 21 months ago by sergz

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.