Opened 19 months ago
Last modified 17 months ago
#5509 new change
Start using ESLint
Reported by: | sergz | Assignee: | |
---|---|---|---|
Priority: | P5 | Milestone: | |
Module: | Libadblockplus | Keywords: | |
Cc: | Blocked By: | #5475, #5552 | |
Blocking: | #5685 | Platform: | Unknown / Cross platform |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description (last modified by sergz)
Background
adblockpluscore starts to use it since #4878, however there are some JS files in libadblockplus as well, so it would be good to use ESLint here too.
It should be a separate target, in particular it should run automatically when tests are run on CI.
Additional info
The following git commits can be helpful 25741472c09c4b82c559ac4c1c7bc45e42ab698c, 84dad1808a24abfc4372b491133f0ae7874dd191, aa6abdc3c7284798be9dc196a6ba4ea493117f51, 57a21982c84589ec03469a7219caadd628b5eae1.
Change History (5)
comment:1 Changed 19 months ago by sergz
- Description modified (diff)
comment:2 Changed 18 months ago by sergz
- Blocked By 5552 added
comment:3 Changed 17 months ago by sergz
- Review URL(s) modified (diff)
comment:4 Changed 17 months ago by hfiguiere
- Blocking 5685 added
comment:5 Changed 17 months ago by abpbot
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 5509 - add ESLint config