Opened 2 years ago

Closed 2 years ago

#5510 closed change (fixed)

Check that in compat.js XMLHttpRequest onload is what we want when error occurs

Reported by: sergz Assignee: hfiguiere
Priority: Unknown Milestone:
Module: Libadblockplus Keywords:
Cc: hfiguiere Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29544685

Description

Background

It seems that we should rather use this["on" + eventName].call(this, event);, namely, onerror, https://github.com/adblockplus/libadblockplus/blob/7446b2d2068b225aeb2645a7097eff6790d6f079/lib/compat.js#L405.

Change History (4)

comment:1 Changed 2 years ago by hfiguiere

  • Owner set to hfiguiere

comment:2 Changed 2 years ago by hfiguiere

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5510 - Call onerror in case of error

comment:4 Changed 2 years ago by hfiguiere

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.