Opened on 08/14/2017 at 01:03:06 PM

Closed on 08/21/2017 at 09:08:32 AM

Last modified on 09/25/2017 at 01:27:26 PM

#5516 closed change (fixed)

Bundle the browser tests and dependencies using webpack, adding module support

Reported by: kzar Assignee: kzar
Priority: P3 Milestone:
Module: Core Keywords:
Cc: trev, fhd, hfiguiere Blocked By:
Blocking: #5079 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

Description (last modified by trev)


Since we're going to start using modules for the content scripts we need to add support for modules to the browser tests in adblockpluscore too.

What to change

  • Modify runBootstrap in chromiumium_process.js to bundle together all the browser test files and any module dependencies using webpack before compiling and running them inside the Chromium process.
  • Have test/browser/_bootstrap.js export the init function, which the test runner can call with the same arguments as before. That way only even though all the browser tests will always be included by webpack, only the ones specified will be run.
  • Remove the loadScript and similar logic from test/browser/_bootstrap.js.
  • Remove the loadScript calls from test/browser/elemHideEmulation.js, instead calling require to include the elemHideEmulation module.

Integration notes

This converts elemHideEmulation into a module, so it needs to be ensured that it can be loaded as such.

Hints for testers

It should be verified that element hiding emulation functionality still works.

Attachments (0)

Change History (5)

comment:1 Changed on 08/14/2017 at 01:20:05 PM by hfiguiere

  • Cc hfiguiere added

comment:2 Changed on 08/16/2017 at 03:57:47 PM by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 08/21/2017 at 09:08:32 AM by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed on 08/29/2017 at 06:40:49 AM by trev

  • Description modified (diff)
  • Priority changed from Unknown to P3
  • Ready set

comment:5 Changed on 09/25/2017 at 01:27:26 PM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Element hiding functionality still works (except for non-regression #5773).

Chrome 52 / 61 / Windows 7
Opera 40 / 47 / Windows 7

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kzar.
Note: See TracTickets for help on using tickets.