Opened 10 months ago

Last modified 5 months ago

#5549 reviewing change

Implement missing error handlings for custom filter lists

Reported by: saroyanm Assignee: agiammarchi
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: greiner Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29674584/

Description (last modified by saroyanm)

Background

After several design iterations we finally have a final version of the new options page (See #5158)

What to change

Implement error handling for the Advanced tab: Invalid custom filter.

Change History (6)

comment:1 Changed 9 months ago by saroyanm

  • Description modified (diff)
  • Summary changed from Implement missing error handlings to Implement missing error handlings for custom filter lists

Add custom filter list dialog error handling will be implemented in #5706

comment:2 Changed 9 months ago by saroyanm

We decided this is not crucial for First Viable Product launch as we don't handle this case in current options page of Chrome using "row" view.

comment:3 Changed 9 months ago by saroyanm

  • Blocking 5158 removed

comment:4 Changed 5 months ago by agiammarchi

  • Owner set to agiammarchi

comment:5 Changed 5 months ago by saroyanm

  • Description modified (diff)

Update the link to point to the specs in Gitlab, as we moved there lately.

comment:6 Changed 5 months ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
Note: See TracTickets for help on using tickets.