Opened 2 years ago

Closed 2 years ago

#5556 closed change (fixed)

Update to use libadblockplus revision hg:566f64c8a2a8

Reported by: sergz Assignee:
Priority: Unknown Milestone:
Module: Libadblockplus-Android Keywords:
Cc: asmirnov Blocked By: #5569, #5617
Blocking: #5643 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29523679/
https://codereview.adblockplus.org/29523682/
https://codereview.adblockplus.org/29524565/
https://codereview.adblockplus.org/29526696/
https://codereview.adblockplus.org/29526710/
https://codereview.adblockplus.org/29527821/
https://codereview.adblockplus.org/29533564/
https://codereview.adblockplus.org/29533572/
https://codereview.adblockplus.org/29536596/
https://codereview.adblockplus.org/29536604/
https://codereview.adblockplus.org/29536629/
https://codereview.adblockplus.org/29537555/

Description (last modified by sergz)

Background

adblockpluscore has been updated in libadblockplus, there are some changes affecting the size of memory usage, therefore it would be good to update libadblockplus in libadblockplus-android as soon as possible at least to measure the current memory usage. For the full list of changes in adblockpluscore introduced into libadblockplus please see #5475.

Ticket Summary Component
#5617 Provide with async executor bound to Platform. Libadblockplus
#5570 Make V8 isolate injectable into JsEngine. Libadblockplus
#5569 Add a temporary possibility to use synchronous interfaces of WebRequest and FileSystem Libadblockplus
#5568 Improve string handling by splitting read strings into only ASCII and non-ASCII strings Libadblockplus
#5552 Use strict mode for all JS in libadblocklus Libadblockplus
#5508 Implement virtual file system in tests. Libadblockplus
#5506 Fix Notification test Libadblockplus
#5475 Update adblockpluscore dependency to revision hg:b935a0402215 Libadblockplus
#5450 Modularize libadblockplus Libadblockplus
#5393 compile issue with latest libadblockplus code for android platform (linux os) Libadblockplus
#5267 Add support of 64 bit android Libadblockplus
#5183 Make interface of FileSystem asynchronous Libadblockplus
#5180 Make interface of WebRequest asynchronous Libadblockplus
#4983 Get rid of Sleep() in the WebRequest test Libadblockplus
#4938 [meta] Unit tests are full of race conditions Libadblockplus
#4832 The API to initialize I/O resources is inherently racy Libadblockplus
#4711 Custom thread class leaks resources on Windows Libadblockplus


e530495163f2Noissue - remove additional empty lineSergei Zabolotskikh
2cb6e4491fc2Noissue - fix overlooked comment for Platform::GetLogSystemSergei Zabolotskikh
233aac8400deNoissue - Updated copyright yearWladimir Palant
7f3818ccb4d1Noissue - fix the value of gyp -Gandroid_ndk_version parameter in accordance to the used Android NDKSergei Zabolotskikh
8b825a798649Noissue - fix running of native tests on androidSergei Zabolotskikh
cd1d9588cc56Noissue - Fix a constructor order warningHubert Figuière
937936b9df5aNoissue - set default values for platform interfaces to nullptrSergei Zabolotskikh
e59e76660ee9Noissue - remove unnecessary sleeps in FileSystemJsObject testsSergei Zabolotskikh
ffd0d8ba35feNoissue - code style: use override for overridden methods of MockFileSystemSergei Zabolotskikh
b16c48c68880Noissue - remove unnecessary including of v8.hSergei Zabolotskikh

What to change

Prepare and update libadblockplus-binaries dependency to libadblockplus hg:566f64c8a2a8 revision as well as adapt the code.

Change History (25)

comment:1 Changed 2 years ago by sergz

  • Review URL(s) modified (diff)

comment:2 Changed 2 years ago by sergz

  • Review URL(s) modified (diff)

comment:3 Changed 2 years ago by sergz

  • Blocked By 5569 added
  • Description modified (diff)

comment:4 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5556 - Update to use libadblockplus revision hg:36e9993fa36c

comment:5 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5556 - Update to use libadblockplus revision hg:36e9993fa36c

comment:6 Changed 2 years ago by asmirnov

  • Review URL(s) modified (diff)

comment:7 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5556 - Update to use libadblockplus revision hg:36e9993fa36c

comment:8 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5556 - Update to use libadblockplus revision hg:36e9993fa36c

comment:9 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5556 - Update to use libadblockplus revision hg:36e9993fa36c

comment:10 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5556 - Update to use libadblockplus revision hg:36e9993fa36c

comment:11 Changed 2 years ago by sergz

  • Review URL(s) modified (diff)

comment:12 Changed 2 years ago by sergz

  • Blocked By 5617 added

comment:13 Changed 2 years ago by sergz

  • Review URL(s) modified (diff)

comment:14 Changed 2 years ago by sergz

  • Review URL(s) modified (diff)

comment:15 Changed 2 years ago by sergz

  • Review URL(s) modified (diff)

comment:16 Changed 2 years ago by sergz

  • Description modified (diff)
  • Summary changed from Update to use libadblockplus revision hg:36e9993fa36c to Update to use libadblockplus revision hg:566f64c8a2a8

New changes simplifying the update had been landed in libadblockplus, therefore the issue description has been updated.

comment:17 Changed 2 years ago by asmirnov

  • Review URL(s) modified (diff)

comment:18 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5556 - Update to use libadblockplus revision hg:566f64c8a2a8

comment:19 Changed 2 years ago by sergz

  • Blocking 5643 added

comment:20 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5556 - Update to use libadblockplus revision hg:566f64c8a2a8

comment:21 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5556 - Update to use libadblockplus revision hg:566f64c8a2a8

comment:22 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5556 - Update to use libadblockplus revision hg:566f64c8a2a8

comment:23 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5556 - Update to use libadblockplus revision hg:566f64c8a2a8

comment:24 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5556 - Update to use libadblockplus revision hg:566f64c8a2a8

comment:25 Changed 2 years ago by sergz

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.