Opened 2 months ago

Closed 2 months ago

Last modified 4 weeks ago

#5558 closed change (fixed)

Make notifications not ignore unknown targets

Reported by: wspee Assignee:
Priority: P3 Milestone:
Module: Core Keywords:
Cc: trev Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29501607/

Description

Background

Currently the notification system will ignore unknown targets:

title.en-US = Test
message.en-US = Test
severity = normal
target = newFeature=111111elf

This means that whenever we add a new target we have to be very careful to also check for the version the target was added, e.g.:

title.en-US = Test
message.en-US = Test
severity = normal
target = newFeature=111111elf extensionVersion>=VERSION_THE_FEATURE_WAS_ADDED

It would be safer if the extension would not show notifications with unknown targets.

What to change

No longer ignore unknown targets, instead don't show a notification with an unknown target.

Change History (6)

comment:1 Changed 2 months ago by trev

  • Priority changed from Unknown to P3
  • Ready set

comment:2 Changed 2 months ago by trev

  • Review URL(s) modified (diff)
  • Sensitive set

comment:3 Changed 2 months ago by trev

  • Sensitive unset

comment:4 Changed 2 months ago by abpbot

A commit referencing this issue has landed:
Issue 5558 - Don't ignore unknown notification targets

comment:5 Changed 2 months ago by wspee

  • Resolution set to fixed
  • Status changed from new to closed

comment:6 Changed 4 weeks ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. This works in Chrome. Unable to test in Opera at the moment due to #5759.

ABP 1.13.3.1838
Chrome 49 / 61 / Windows 7

Note: See TracTickets for help on using tickets.