Opened on 08/23/2017 at 09:27:07 AM

Closed on 08/25/2017 at 09:19:59 AM

Last modified on 09/25/2017 at 01:17:31 PM

#5558 closed change (fixed)

Make notifications not ignore unknown targets

Reported by: wspee Assignee:
Priority: P3 Milestone:
Module: Core Keywords:
Cc: trev Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):



Currently the notification system will ignore unknown targets:

title.en-US = Test
message.en-US = Test
severity = normal
target = newFeature=111111elf

This means that whenever we add a new target we have to be very careful to also check for the version the target was added, e.g.:

title.en-US = Test
message.en-US = Test
severity = normal
target = newFeature=111111elf extensionVersion>=VERSION_THE_FEATURE_WAS_ADDED

It would be safer if the extension would not show notifications with unknown targets.

What to change

No longer ignore unknown targets, instead don't show a notification with an unknown target.

Attachments (0)

Change History (6)

comment:1 Changed on 08/23/2017 at 10:57:01 AM by trev

  • Priority changed from Unknown to P3
  • Ready set

comment:2 Changed on 08/25/2017 at 09:06:02 AM by trev

  • Review URL(s) modified (diff)
  • Sensitive set

comment:3 Changed on 08/25/2017 at 09:06:14 AM by trev

  • Sensitive unset

comment:4 Changed on 08/25/2017 at 09:10:28 AM by abpbot

A commit referencing this issue has landed:
Issue 5558 - Don't ignore unknown notification targets

comment:5 Changed on 08/25/2017 at 09:19:59 AM by wspee

  • Resolution set to fixed
  • Status changed from new to closed

comment:6 Changed on 09/25/2017 at 01:17:31 PM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. This works in Chrome. Unable to test in Opera at the moment due to #5759.

Chrome 49 / 61 / Windows 7

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Note: See TracTickets for help on using tickets.