Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#5562 closed change (fixed)

Move Edge storage to IndexedDB

Reported by: oleksandr Assignee: oleksandr
Priority: Unknown Milestone:
Module: Platform Keywords:
Cc: sebastian, kzar Blocked By:
Blocking: Platform: Edge
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29526591/

Description (last modified by kzar)

Background

With #5315 we have added support for Microsoft Edge to the adblockpluschrome master bookmark. However builds from that code result in a very sub-optimal extension because using storage.local for storing filter lists is very slow in Edge. Even the latest Windows Insider builds (16273, August 23rd 2017) have this issue, so it is unlikely to get fixed in the Fall Update.

In #4721 we have already implemented the code to use IndexedDB for storage of filters in Microsoft Edge. It is working much faster, so we should move to that.

What to change

Change filter list storage mechanism for edge bookmark to IndexedDB.

Hint for testers

We want to make sure that we don't lose user's settings when updating from previous versions of ABP for Edge. So making sure the custom filters, whitelisted domains and selected filter list is a good idea. Also just generally making sure the storage works as expected would be appreciated.

Change History (6)

comment:1 Changed 3 months ago by oleksandr

  • Review URL(s) modified (diff)

comment:2 Changed 3 months ago by oleksandr

  • Status changed from new to reviewing

comment:3 Changed 3 months ago by abpbot

A commit referencing this issue has landed:
Issue 5562 - Use IndexedDB for storage in Edge bookmark

comment:4 Changed 3 months ago by oleksandr

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 3 months ago by oleksandr

  • Description modified (diff)

comment:6 Changed 3 months ago by kzar

  • Description modified (diff)
Note: See TracTickets for help on using tickets.