Opened 2 years ago

Closed 2 years ago

#5573 closed change (fixed)

Add a CSS reset to website-defaults

Reported by: ire Assignee: ire
Priority: P2 Milestone:
Module: Websites Keywords:
Cc: juliandoucette, wspee Blocked By:
Blocking: #4633, #5607 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29529767/

Description

Background

The current website-defaults SCSS includes some Normalize.css styles to normalize styles across browsers by default. This does not remove many default styles that are applied by browsers, e.g. padding, margins, font styling. We want to include a reset that would create more of a blank slate on which to build our own styles upon.

What to change

  1. Research what reset styles are needed for particular elements
  2. Create a _reset.scss file to include in website-defaults

Change History (6)

comment:1 Changed 2 years ago by ire

  • Blocking 4633 added
  • Owner set to ire
  • Priority changed from Unknown to P3
  • Ready set

comment:2 Changed 2 years ago by ire

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 2 years ago by ire

  • Blocking 5607 added

comment:4 Changed 2 years ago by juliandoucette

  • Priority changed from P3 to P2

Bumped priority because of blocking.

comment:5 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5573 - Add a CSS reset to website-defaults

comment:6 Changed 2 years ago by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.