Opened 2 years ago

Closed 2 years ago

#5574 closed change (fixed)

Update to current jQuery and jQuery UI versions

Reported by: trev Assignee: trev
Priority: P1 Milestone: Adblock-Plus-3.0-for-Firefox
Module: User-Interface Keywords:
Cc: sebastian, greiner Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29527615/

Description (last modified by sebastian)

Background

Mozilla requires at least jQuery 2.0 for extensions, our jQuery 1.7.1 is considered unsafe. However, when updating jQuery, jQuery UI has to be updated as well, since our version (jQuery UI 1.8) is incompatible with jQuery 1.9 and newer versions.

What to change

Update to current jQuery and jQuery UI versions, make the necessary adjustments to our code.

Hints for testers

This change effects the (old) options page and the "Block element" dialog. Some visual minor changes are to be expected, as long as they don't impair the usability. Also make sure that all UI functionality is still working as before, and that no JavaScript errors are logged in the developer tools.

Change History (9)

comment:1 Changed 2 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 2 years ago by trev

  • Component changed from Platform to User-Interface

comment:3 Changed 2 years ago by greiner

  • Cc greiner added
  • Platform changed from Unknown / Cross platform to Firefox
  • Priority changed from Unknown to P1
  • Ready set

comment:4 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5574 - Update to current jQuery and jQuery UI versions

comment:5 Changed 2 years ago by trev

  • Milestone set to Adblock-Plus-for-Chrome-Opera-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 2 years ago by sebastian

  • Description modified (diff)

comment:7 Changed 2 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. UI still works as expected and no errors appear to occur.

ABP 1.13.13.1838
Chrome 49 / 60 / Windows 7
Opera 36 / 46 / Windows 7

comment:8 Changed 2 years ago by sebastian

  • Milestone changed from Adblock-Plus-1.13.4-for-Chrome-Opera to Adblock-Plus-for-Chrome-Opera-next
  • Resolution fixed deleted
  • Status changed from closed to reopened

This change has been backed out, for now, due to #5748.

comment:9 Changed 2 years ago by sebastian

  • Resolution set to fixed
  • Status changed from reopened to closed

This change was only backed out in master prior to the Adblock plus 1.13.4 release. It was never backed out in next wich now became the new master. Therefore closing again.

Note: See TracTickets for help on using tickets.