Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#5577 closed change (fixed)

let build.py allow non-numerical build numbers for gecko-webext

Reported by: tlucas Assignee:
Priority: P1 Milestone:
Module: Automation Keywords:
Cc: sebastian, trev Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29527695/

Description (last modified by sebastian)

Background

We want to switch our beta channel on AMO to the webext builds. Therefore the version numbers must be in the format like *.*.*.*-beta.

What to change

Change build.py to allow non-numerical build numbers for gecko-webext builds, the way it is already allowed for legacy gecko builds.

Change History (5)

comment:1 Changed 2 years ago by sebastian

  • Description modified (diff)
  • Priority changed from Unknown to P1
  • Ready set

comment:2 Changed 2 years ago by tlucas

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5577 - allow non-numerical build-nums for gecko-webext

comment:4 Changed 2 years ago by tlucas

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 2 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Building with non-numerical characters in the file/build name works as expected.

adblockpluschrome / 1846:44197859df84

Note: See TracTickets for help on using tickets.