Opened 3 months ago

Closed 3 months ago

Last modified 2 months ago

#5578 closed change (fixed)

Update buildtools dependency to hg:0234926280f1

Reported by: tlucas Assignee:
Priority: P1 Milestone: Adblock-Plus-1.13.4-for-Chrome-Opera
Module: Platform Keywords:
Cc: sebastian, trev Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29527716

Description (last modified by tlucas)

What to change

Update the buildtools dependency in adblockpluschrome to:

hg git
0234926280f1 48bb35a

Included changes


Hints for testers

You should be able to create gecko-webext builds with non-numerical buildnums, e.g.
./build.py -t gecko-webext build -b 1889-beta -> adblockplusfirefox-2.9.0.1889-beta.xpi

Change History (10)

comment:1 Changed 3 months ago by tlucas

  • Description modified (diff)

comment:2 Changed 3 months ago by tlucas

  • Description modified (diff)

comment:3 Changed 3 months ago by tlucas

  • Cc sebastian trev added
  • Description modified (diff)

comment:4 Changed 3 months ago by tlucas

  • Summary changed from Update buildtools dependency to hg: to Update buildtools dependency to hg:0234926280f1

comment:5 Changed 3 months ago by sebastian

  • Priority changed from Unknown to P1
  • Ready set

comment:6 Changed 3 months ago by tlucas

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed 3 months ago by abpbot

A commit referencing this issue has landed:
Issue 5578 - Update buildtools dependency to hg:0234926280f1

comment:8 Changed 3 months ago by tlucas

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:9 Changed 3 months ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-next

comment:10 Changed 2 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Building with non-numerical characters in the file/build name works as expected.

adblockpluschrome / 1846:44197859df84

Note: See TracTickets for help on using tickets.