Opened 23 months ago

Closed 23 months ago

Last modified 21 months ago

#5579 closed change (fixed)

Download json file with locale revisions for multilocale build

Reported by: diegocarloslima Assignee: diegocarloslima
Priority: P2 Milestone: Adblock-Browser-for-Android-1.3.0
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29527865/

Description (last modified by diegocarloslima)

Background

Starting from Firefox 53, Mozilla has stopped to consistently add release tags to their locale repositories (e.g. Esperanto locale doesn't have Fennec 53 tags and so on). After talking with a Mozilla dev, he advised me to use instead these json files, which contains the revision for each locale for a specific release.

What to change

We need to adjust our multilocale build system in order to be able to set one of those json url in our adblockbrowser-cfg.py file. We'll need to download that json file, parse it and checkout the correct revision for each locale in the pull-locale-source step.

Hints for testers

This issue can be verified working by switching the browser language (either by the changing in the device settings or in ABB settings -> General -> Language) and checking if the strings displayed are in conformity with the strings defined in the l10n json file. Some of the strings defined in the json file: English-UK , Spanish-Spain , German.

Change History (7)

comment:1 Changed 23 months ago by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 23 months ago by diegocarloslima

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 22 months ago by traynard

If this item is testable, please provide some testing information/instructions

comment:5 Changed 22 months ago by diegocarloslima

  • Description modified (diff)

comment:6 Changed 22 months ago by diegocarloslima

@traynard: Added hints for testers in the ticket description

comment:7 Changed 21 months ago by traynard

  • Verified working set
Note: See TracTickets for help on using tickets.