Opened 21 months ago

Closed 21 months ago

Last modified 20 months ago

#5580 closed defect (fixed)

Multilocale build fails due to missing search engine plugin file

Reported by: diegocarloslima Assignee: diegocarloslima
Priority: P2 Milestone: Adblock-Browser-for-Android-1.3.0
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29527868/

Description

Mozilla has introduced the concept of hidden search plugins, which shows in the list.txt file but they don't have a .xml file. With that, our abb-transform-locales step fails when it tries to find the .xml file for google:hidden. We need to skip those entries.

Change History (6)

comment:1 Changed 21 months ago by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 21 months ago by diegocarloslima

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 20 months ago by traynard

If this item is testable, please provide some testing information/instructions

comment:5 Changed 20 months ago by diegocarloslima

@traynard: This is a build time issue. I believe that the best way to test it is by building the ABB project and checking if it performs successfully. Since I was able to build the project in order to generate the release candidate .apk, I think that we might consider this as verified working.

comment:6 Changed 20 months ago by traynard

  • Verified working set
Note: See TracTickets for help on using tickets.