Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#5581 closed defect (fixed)

Multilocale build fails to copy gecko-unsigned-unaligned.apk

Reported by: diegocarloslima Assignee: diegocarloslima
Priority: P2 Milestone: Adblock-Browser-for-Android-1.3.0
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29527871/
https://codereview.adblockplus.org/29559713/

Description (last modified by diegocarloslima)

Mozilla has changed the name of the generated unsigned .apk artefact from gecko-unsigned-unaligned.apk to fennec-[APP_VERSION].multi.android-[ARCHITECTURE]-unsigned-unaligned.apk. Also, the architecture part for x86 builds has changed to i386. We need to update our build.py script in order to take into consideration that change and properly copy/rename the unsigned .apk file to adblockbrowser-[APP_VERSION]-[BUILD_ID]-[ARCHITECTURE].apk.

Change History (11)

comment:1 Changed 2 years ago by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 2 years ago by abpbot

comment:3 Changed 2 years ago by diegocarloslima

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 2 years ago by traynard

If this item is testable, please provide some testing information/instructions

comment:5 Changed 2 years ago by diegocarloslima

@traynard: This is a build time issue. I believe that the best way to test it is by building the ABB project and checking if it performs successfully. Since I was able to build the project in order to generate the release candidate .apk, I think that we might consider this as verified working.

comment:6 Changed 2 years ago by diegocarloslima

  • Description modified (diff)

comment:7 Changed 2 years ago by diegocarloslima

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:8 Changed 2 years ago by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from reopened to reviewing

comment:9 Changed 2 years ago by abpbot

comment:10 Changed 2 years ago by diegocarloslima

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:11 Changed 2 years ago by traynard

  • Verified working set

Verified working per diego's comment.

Note: See TracTickets for help on using tickets.