Opened 3 months ago

Closed 3 months ago

Last modified 2 months ago

#5582 closed change (fixed)

Workaround Edge bug in tabs.query

Reported by: oleksandr Assignee: oleksandr
Priority: P2 Milestone: Adblock-Plus-1.13.4-for-Chrome-Opera
Module: Platform Keywords:
Cc: sebastian, Ross Blocked By:
Blocking: Platform: Edge
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29527877

Description

Background

Edge does not support querying tabs with URLs that have ms-browser-extension:// protocol. See https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/8094141/ and https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/8604703/. We rely on that to find existing options page.

What to change

Either remove the code that tries to detect already opened Options page, or workaround the bug by searching using page title instead.

Change History (8)

comment:1 Changed 3 months ago by oleksandr

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 months ago by sebastian

  • Priority changed from Unknown to P2
  • Ready set

comment:3 Changed 3 months ago by abpbot

A commit referencing this issue has landed:
Issue 5582 - Workaround Edge bug in tabs.query

comment:4 Changed 3 months ago by oleksandr

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 3 months ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-next

comment:6 Changed 2 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Options page opens as expected and existing options tab is focused if already open.

ABP 0.9.11.1842
Edge 40 / Windows 10

comment:7 Changed 2 months ago by sebastian

  • Cc Ross added

Please make sure to not only test on the browser the change is supposed to have any effect on, but also verify that the change doesn't break anything on other platforms (Chrome in particular).

comment:8 Changed 2 months ago by Ross

Double checked Chrome/Opera behavior.

ABP 0.13.3.1838
Chrome 49 / 60 Windows 7
Opera 36 / 46 / Windows 7

Note: See TracTickets for help on using tickets.