Opened 3 years ago

Last modified 3 years ago

#5584 closed change

Update adblockpluscore dependency 217eff0504a5 — at Version 13

Reported by: hfiguiere Assignee: hfiguiere
Priority: P2 Milestone: Adblock-Plus-1.13.4-for-Chrome-Opera
Module: Platform Keywords:
Cc: fhd, trev, sebastian, kzar Blocked By: #5535
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29529646/

Description (last modified by trev)

Background

Update adblockpluscore dependency

What to change

Update adblockpluscore dependency to

hg git
217eff0504a5 48eddbc

Make sure that elemHideEmulation is packaged as a module (see #5516).

Included changes


adffd8564570 Noissue - Refactored notification target checking (checkTarget) to make it more easily expandable Winsley von Spee
d84358f9e0c0 Noissue - Added testcase to show that unknown notification targets are ignored Winsley von Spee
e775d9190f02 Noissue - Enable source map for the tests Hubert Figuière
3af11978db00 Noissue - Updated copyright year Wladimir Palant
8a9c308bb8fb Noissue - Reorder chromium_process.js imports Dave Barker
b935a0402215 Noissue - Throw an error if the client code doesn't load Hubert Figuière
1a633dad14b4 Noissue - Remove unused reportError Hubert Figuière

Hints for testers

  • Issues #5459, #5460, #5558 implement changes to notification handling. Testing the notification mechanism is non-trivial unfortunately.
  • Issues #5079, #5339, #5381, #5422, #5436, #5438, #5516 all affect element hiding emulation functionality, please refer to the descriptions in the respective issues.
  • Issue #5000 isn't part of the list but has been resolved implicitly by #5438 and #5339 and should be retested.
  • The commits without issue have no impact on the build or affect functionality already covered by one of the issues above.

Change History (13)

comment:1 Changed 3 years ago by hfiguiere

  • Description modified (diff)

comment:2 Changed 3 years ago by hfiguiere

  • Cc fhd trev sebastian added

comment:3 Changed 3 years ago by hfiguiere

  • Cc kzar added

comment:4 Changed 3 years ago by hfiguiere

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 3 years ago by hfiguiere

  • Description modified (diff)

comment:6 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 5584 - Update adblockpluscore dependency to hg:217eff0504a5

comment:7 Changed 3 years ago by hfiguiere

  • Milestone set to Adblock-Plus-for-Chrome-Opera-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed 3 years ago by hfiguiere

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:9 Changed 3 years ago by hfiguiere

  • Owner set to hfiguiere

We should revert the patch for now. We are missing issue #5535

comment:10 Changed 3 years ago by hfiguiere

  • Blocked By 5535 added

comment:12 Changed 3 years ago by sebastian

  • Priority changed from Unknown to P2
  • Ready set

comment:13 Changed 3 years ago by trev

  • Description modified (diff)
Note: See TracTickets for help on using tickets.