Opened 3 years ago

Last modified 3 years ago

#5584 closed change

Update adblockpluscore dependency 217eff0504a5 — at Version 5

Reported by: hfiguiere Assignee:
Priority: P2 Milestone: Adblock-Plus-1.13.4-for-Chrome-Opera
Module: Platform Keywords:
Cc: fhd, trev, sebastian, kzar Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29529646/

Description (last modified by hfiguiere)

Background

Update adblockpluscore dependency

What to change

Update adblockpluscore dependency to

hg git
217eff0504a5 48eddbc

Included changes


adffd8564570 Noissue - Refactored notification target checking (checkTarget) to make it more easily expandable Winsley von Spee
d84358f9e0c0 Noissue - Added testcase to show that unknown notification targets are ignored Winsley von Spee
e775d9190f02 Noissue - Enable source map for the tests Hubert Figuière
3af11978db00 Noissue - Updated copyright year Wladimir Palant
8a9c308bb8fb Noissue - Reorder chromium_process.js imports Dave Barker
b935a0402215 Noissue - Throw an error if the client code doesn't load Hubert Figuière
1a633dad14b4 Noissue - Remove unused reportError Hubert Figuière

Hints for testers

  • We have changed path for some files. Check the add-on work on overall on all the platform.
  • Issue #5422 and #5436 have fileter test case that were failing. Make sure :-abp-has() still work as advertised.
  • The add-on should work again on Chrome 49 and 50.
  • We can now match element based on CSS properties in their ::before and ::after pseudo-elements. See issue #5339 for details
  • We new detect changes in the DOM which mean we re-run the filters as it goes. Attention should be paid to performance. If there is no #?# filters for the domain, this shouldn't occur. Otherwise it should not happen too often. This is issue #5438.
  • Issue #5000 that is not mentioned in this list should be verified. It works now with a combination of #5438 and #5339. Make sure to check the appropriate filter in the issue description.

Change History (5)

comment:1 Changed 3 years ago by hfiguiere

  • Description modified (diff)

comment:2 Changed 3 years ago by hfiguiere

  • Cc fhd trev sebastian added

comment:3 Changed 3 years ago by hfiguiere

  • Cc kzar added

comment:4 Changed 3 years ago by hfiguiere

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 3 years ago by hfiguiere

  • Description modified (diff)
Note: See TracTickets for help on using tickets.