Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#5587 closed change (fixed)

Use dedicated mobile options page in Firefox Mobile

Reported by: greiner Assignee: mjethani
Priority: P2 Milestone: Adblock-Plus-3.0-for-Firefox
Module: Platform Keywords:
Cc: sebastian, mjethani, trev, wspee, saroyanm Blocked By: #5384, #5586
Blocking: #5803 Platform: Firefox Mobile
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29536764/
https://codereview.adblockplus.org/29564735/

Description (last modified by sebastian)

Background

In #5384 we introduced we introduced a dedicated mobile version of our new options page for Adblock Plus for Firefox Mobile. However, it's not being used anywhere yet.

What to change

  • Update adblockplusui dependency to bcdec68923d6
  • Include the following resources in the gecko-webext build:
    • adblockplusui/mobile-options.html
    • adblockplusui/mobile-options.js
    • adblockplusui/skin/abp-logo.svg
    • adblockplusui/skin/mobile-options.css
    • adblockplusui/skin/mobile/checkmark.svg
    • adblockplusui/skin/mobile/toggle.svg
    • adblockplusui/skin/mobile/trash.svg
    • adblockplusui/locale/*/mobile-options.json
  • Use mobile-options.html when running the extension on Firefox Mobile but keep using options.html when running the extension on Firefox Desktop
  • Dispatch the following message after opening the options page for a tab (e.g. in the callback of ext.showOptions()) so that it will show the UI for en-/disabling Adblock Plus for that domain:
    {
      type: "app.respond",
      action: "showPageOptions",
      args: [
        {
          // Base domain of tab the options page should refer to
          host: "example.com",
          // Indicates whether or not the given domain is whitelisted
          whitelisted: true|false
        }
      ]
    }
    

What to test

  • Check that the options page opens up and that it shows all currently enabled filter lists as well as that it reflects the state of Acceptable Ads correctly.
  • Check that the options page shows a toggle for en-/disabling ad blocking for the domain when opening it for a tab.
  • Check that clicking on abp:subscribe links will open the options page and cause a confirmation dialog to be shown.
  • Make sure that on desktop, the desktop options page shows up, and behaves as it did before, on all platforms.

Change History (15)

comment:1 Changed 2 years ago by greiner

  • Description modified (diff)

Updated description to reflect recent changes (54db9974cb7a, bcdec68923d6).

comment:2 Changed 2 years ago by greiner

  • Description modified (diff)

comment:3 Changed 2 years ago by greiner

  • Description modified (diff)

Added requirement regarding its domain-specific UI as well as "What to test" section.

comment:4 Changed 2 years ago by greiner

  • Description modified (diff)

Updated description to describe usage with ext.showOptions() instead of "app.open".

comment:5 Changed 2 years ago by sebastian

  • Cc sebastian mjethani trev added
  • Priority changed from Unknown to P2
  • Ready set

comment:6 Changed 2 years ago by mjethani

  • Owner set to mjethani

comment:7 Changed 2 years ago by mjethani

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:8 Changed 2 years ago by greiner

  • Cc wspee added

comment:9 Changed 2 years ago by sebastian

  • Blocking 5803 added

comment:10 Changed 2 years ago by saroyanm

  • Cc saroyanm added

comment:11 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5587 - Use options module

comment:12 Changed 2 years ago by mjethani

  • Review URL(s) modified (diff)

comment:13 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5587, 5748 - Use mobile options page on Firefox for Android

comment:14 Changed 2 years ago by mjethani

  • Milestone set to Adblock-Plus-for-Chrome-Opera-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:15 Changed 2 years ago by sebastian

  • Description modified (diff)
Note: See TracTickets for help on using tickets.