Opened 2 years ago

Closed 2 years ago

#5595 closed defect (fixed)

Add missing app icons to project & clean up file names.

Reported by: CraftyDeano Assignee: dzhang
Priority: Unknown Milestone:
Module: Adblock-Plus-for-iOS/macOS Keywords: app icon, iOS
Cc: mario, ashephard, dzhang, tiago, martin Blocked By:
Blocking: Platform: iOS
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29542813/

Description (last modified by ashephard)

Environment

The current version of Xcode is giving warnings for missing icon files and rename existing files.
For ABP: "A 83.5x83.5@2x app icon is required for iPad apps targeting iOS 9.0 and later."
For ABP Action Extension: "A 83.5x83.5@2x app icon is required for iPad apps targeting iOS 9.0 and later."

Also, this will be a good time to standardise the naming convention for app icons to something more explicit.

Example: appicon-40@… instead of appicon-120.png

Full Iconset Sizes Required:
20x20px
29x29px
40x40px
60x60px
87x87px
167x167px
1024x1024px

How to reproduce

  1. Build project
  2. Check warnings

Attachments (2)

ABB - iOS Icon.zip (93.2 KB) - added by martin 2 years ago.
Here's a an archive with all sizes needed (as per Apple's documentation). Check those out and let me know if something needs fixing.
ABP - iOS Icon.zip (68.3 KB) - added by martin 2 years ago.
Updated ticket with archive containing icons for ABP

Download all attachments as: .zip

Change History (8)

comment:1 Changed 2 years ago by mario

  • Cc tiago martin added

@Tiago, Martin, can you provide the missing icons?

comment:2 Changed 2 years ago by ashephard

There is a codereview linked to this (https://codereview.adblockplus.org/29541880/), which will add a requirement for a 1024x1024px in the app.

Last edited 2 years ago by ashephard (previous) (diff)

comment:3 Changed 2 years ago by ashephard

  • Description modified (diff)

Changed 2 years ago by martin

Here's a an archive with all sizes needed (as per Apple's documentation). Check those out and let me know if something needs fixing.

Changed 2 years ago by martin

Updated ticket with archive containing icons for ABP

comment:4 Changed 2 years ago by dzhang

  • Owner set to dzhang

comment:5 Changed 2 years ago by ashephard

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 2 years ago by dzhang

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.