Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#5596 closed change (fixed)

Update the buildtools dependency to ba4805b5eda4

Reported by: kzar Assignee: kzar
Priority: P2 Milestone: Adblock-Plus-1.13.4-for-Chrome-Opera
Module: Platform Keywords:
Cc: sebastian, tlucas Blocked By: #5559
Blocking: #5535, #5560 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29531669/

Description (last modified by sebastian)

Background

The latest version of ensure_dependencies.py will attempt to install Node.js dependencies when updating and cloning dependencies. We need to update the buildtools dependency and the copy of ensure_dependencies.py used by adblockpluschrome before we start adding Node.js dependencies to buildtools.

What to change

  • Update the buildtools dependency to ba4805b5eda4. (No other changes will be included.)
  • Make sure to include the updated copy of ensure_dependencies.py

Hints for testers

This dependency update has no effect on the (current) builds.

Change History (5)

comment:1 Changed 2 years ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5596 - Update buildtools dependency to ba4805b5eda4

comment:3 Changed 2 years ago by kzar

  • Description modified (diff)
  • Milestone set to Adblock-Plus-for-Chrome-Opera-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 2 years ago by sebastian

  • Description modified (diff)

comment:5 Changed 2 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Does not look to have affected current builds.

ABP 1.13.13.1838
Chrome 49 / 60 / Windows 7
Opera 36 / 46 / Windows 7

Note: See TracTickets for help on using tickets.