Opened 12 months ago

Last modified 8 months ago

#5600 new change

CMS Should extract translations from crowdin even if locale dir does not exist

Reported by: jsonesen Assignee: jsonesen
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: kvas, sebastian, juliandoucette, rhowell Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by jsonesen)

Background

Currently, the script behaves as though the local repository is the master copy which means that if there are new locales on the crowdin project which have not been added to the repository then the new locale is not synced. Mercurial does not recognize empty directories either so a file must also be placed there.

What to change

Change the CMS translations sync script to unpack new upstream locale directory and translation files

Change History (8)

comment:1 Changed 12 months ago by jsonesen

  • Summary changed from CMS Should extract all translations from crowdin even if locale dir does not exist in tip of repo to CMS Should extract translations from crowdin if locale dir does not exist in tip of repo

comment:2 Changed 12 months ago by kvas

  • Priority changed from Unknown to P3
  • Ready set

comment:3 Changed 11 months ago by jsonesen

  • Summary changed from CMS Should extract translations from crowdin if locale dir does not exist in tip of repo to CMS Should extract translations from crowdin even if locale dir does not exist

comment:4 Changed 9 months ago by jsonesen

  • Owner set to jsonesen
  • Ready unset

comment:5 Changed 9 months ago by kvas

  • Ready set

comment:6 Changed 8 months ago by jsonesen

  • Cc kzar added

comment:7 follow-up: Changed 8 months ago by jsonesen

  • Description modified (diff)

@julian
Should the sync script now just pull new upstream locales into the project directory without any additional steps from you (ie creating directories etc)?

@kzar
I am not sure if the sync script should be changed or if the list_locales function in sources.py should be changed here, I suppose if Julian does'nt want to manually add new directories then it would be an new feature to the sync script, what do you think?

Last edited 8 months ago by jsonesen (previous) (diff)

comment:8 in reply to: ↑ 7 Changed 8 months ago by kzar

  • Cc kzar removed

Replying to jsonesen:

@kzar
I am not sure if the sync script should be changed or if the list_locales function in sources.py should be changed here, I suppose if Julian does'nt want to manually add new directories then it would be an new feature to the sync script, what do you think?

The sync script IMO, probably the configure_locales function but it has been some time since I worked on this.

Note: See TracTickets for help on using tickets.