Opened 2 years ago

Closed 2 years ago

#5603 closed change (fixed)

[emscripten] Support references in parameters of exported functions

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: Core Keywords:
Cc: Blocked By:
Blocking: #4122 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29532626/

Description

Background

For parameters of functions exported to JavaScript, we currently only support passing objects by pointer. We should support passing by reference as well, so that the parameter is guaranteed to be non-null.

What to change

  • Change bindings code to support reference types.
  • Make sure that passing objects by reference generates an additional check so that passing in null will throw.
  • Convert pointer parameters to references where appropriate.

Change History (5)

comment:1 Changed 2 years ago by trev

  • Summary changed from [emscripten] to [emscripten] Support references in parameters of exported functions

comment:2 Changed 2 years ago by trev

  • Owner set to trev

comment:3 Changed 2 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 2 years ago by abpbot

comment:5 Changed 2 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.