Opened 2 years ago

Closed 2 years ago

#5604 closed change (fixed)

[emscripten] Put BINDINGS_EXPORTED after the return type consistently

Reported by: trev Assignee: trev
Priority: P4 Milestone:
Module: Core Keywords:
Cc: Blocked By:
Blocking: #4122 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29532613/

Description

Background

Currently, we sometimes have BINDINGS_EXPORTED before the function return type, sometimes after it.

What to change

Put BINDINGS_EXPORTED after the return type consistently, following the convention from EMSCRIPTEN_KEEPALIVE.

Change History (5)

comment:1 Changed 2 years ago by trev

  • Blocking 4122 added

comment:2 Changed 2 years ago by trev

  • Owner set to trev

comment:3 Changed 2 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 2 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.