Opened 2 years ago

Closed 2 years ago

#5607 closed change (fixed)

Namespace content styles in website-defaults

Reported by: ire Assignee: ire
Priority: P2 Milestone:
Module: Websites Keywords: goodfirstbug
Cc: juliandoucette, wspee, ire, saroyanm Blocked By: #5573
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29538612

Description

Background

In 5573 we will add a CSS reset to website-deaults, which will remove many default styles that are applied by browsers to native elements, e.g. padding, margins, font styling.

We want these styles to be applied to content blocks.

What to change

Add default styling to native elements, e.g headings, lists, but namespaced.

Change History (7)

comment:1 Changed 2 years ago by ire

  • Blocked By 5573 added

comment:2 Changed 2 years ago by juliandoucette

  • Priority changed from P3 to P2

Bumped priority because of blocking.

comment:3 Changed 2 years ago by juliandoucette

  • Cc ire saroyanm added
  • Keywords goodfirstbug added
  • Ready set

comment:4 Changed 2 years ago by ire

  • Owner set to ire

comment:5 Changed 2 years ago by ire

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5607 - Namespace content styles in website-defaults

comment:7 Changed 2 years ago by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.