Opened 2 years ago

Last modified 20 months ago

#5613 closed change

Add an option to hide the "Share this number" and the social media buttons from the ABP toolbar button menu — at Version 9

Reported by: darkblue Assignee:
Priority: P3 Milestone: Adblock-Plus-3.0.3-for-Chrome-Opera-Firefox
Module: User-Interface Keywords: goodfirstbug
Cc: greiner, martin, jeen, kzar, saroyanm Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29692555

Description (last modified by greiner)

Environment

Using Chrome 60 with ABP stable 1.13.3
and Firefox Nightly 57 with ABP dev 2.99.0.1832
in windows 10.

Background

Currently in ABP stable for Chrome as well as in ABP dev (WebExtension) for Firefox Nightly
when you click the ABP toolbar button and so the menu appears,
there is a "Share this number" text and social media buttons,
below the blocked ads counters "x on this page, y in total".

For reference, ABP stable for Firefox never had this text and buttons in its toolbar button menu.
I understand their purpose, but I'd like to have to option to hide them.

Here is a screenshot from ABP stable for chrome and a mockup I made with my suggestion:
https://i.imgur.com/qeYQgU5.jpghttps://i.imgur.com/oQpTWJE.jpg

See also https://adblockplus.org/forum/viewtopic.php?f=4&t=54027

What to change

Remove #share element from icon popup and any code it depends on.

Change History (9)

comment:1 Changed 2 years ago by greiner

  • Cc greiner added
  • Component changed from Unknown to User-Interface
  • Description modified (diff)

I'd imagine that we could introduce such a preference if we accomplish to nicely integrate this into the UI. Another option would be to get rid of the share section alltogether in case it turns out that it's not providing enough value but that might be difficult to determine.

Anyway, I'll check back with our Product team to see what they think.

comment:2 Changed 2 years ago by Anke

I also wish, ABP's share buttons were optional.

Being able to block social buttons on websites while at the same time providing share buttons with tracking potential within the extension that cannot be deactivated seems rather non-credible.

comment:3 Changed 2 years ago by greiner

  • Cc martin jeen added

comment:4 Changed 2 years ago by kzar

  • Cc kzar added

FWIW these buttons seem pointless to me as well, why would you ever share a message like "I blocked 23 adverts today" with your friends?

comment:5 Changed 2 years ago by jeen

Martin has been working on a new UI update for the flyout menu which will remove this feature

comment:6 Changed 2 years ago by saroyanm

  • Cc saroyanm added

comment:7 Changed 22 months ago by greiner

@jeen Since the new UI will still be a few months away, what about already removing the social media buttons? That way we could also see what impact removing it might have in which case we could take that into consideration before releasing the new UI.

comment:8 Changed 22 months ago by jeen

@greiner Good idea - the new design already has it removed anyway, and I would be in favour of removing it from the existing design too.

comment:9 Changed 22 months ago by greiner

  • Description modified (diff)
  • Keywords goodfirstbug added
  • Priority changed from Unknown to P3
  • Ready set
Note: See TracTickets for help on using tickets.