Opened 19 months ago

Last modified 18 months ago

#5629 new change

Fix all edge cases caused by flexible root element for new options page

Reported by: saroyanm Assignee:
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: greiner, juliandoucette Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

After several design iterations we finally have a final version of the new options page (See #5158), but we currently are using fixed root element size.

What to change

Be sure that removing flexible root element do not cause issues in layout (e.g. buttons and tabs overflow in sidebar) and make it flexible again.

Change History (3)

comment:1 follow-up: Changed 19 months ago by greiner

Are we sure that this is the expected behavior?

While the spec defines it as `0.3em + 13.2em + 46.3em + 0.3em`, it's unclear whether it's expected to occupy the entire space or whether we should merely center all the UI elements horizontally in which case the width would remain unchanged.

comment:2 in reply to: ↑ 1 Changed 19 months ago by saroyanm

Replying to greiner:

Are we sure that this is the expected behavior?

While the spec defines it as `0.3em + 13.2em + 46.3em + 0.3em`, it's unclear whether it's expected to occupy the entire space or whether we should merely center all the UI elements horizontally in which case the width would remain unchanged.

I don't think that the width is the issue (if I understand your comment correctly) in this case, but I agree that we should find out final behavior of the sidebar.

The only issue currently I encounter is that the Buttons aligned to the bottom of the sidebar being overflown on the tabs which aren't aligned vertically.

comment:3 Changed 18 months ago by saroyanm

  • Blocking 5158 removed
Note: See TracTickets for help on using tickets.