Opened 2 years ago

Closed 7 days ago

#5630 closed change (worksforme)

Marking newly added table items

Reported by: saroyanm Assignee:
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: greiner, juliandoucette Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

After several design iterations we finally have a final version of the new options page (See #5158), but currently we only marking newly added Whitelisted domain, by moving it into the top of the list, while according to the specification and style guide Newly added filter lists and languages are also having highlight.

What to change

Add highlight to the newly added filter list and languages as specified.

Change History (5)

comment:1 Changed 2 years ago by saroyanm

  • Blocking 5158 added

comment:2 Changed 2 years ago by saroyanm

  • Blocking 5158 removed

comment:3 follow-up: Changed 19 months ago by agiammarchi

currently we only marking newly added Whitelisted domain, by moving it into the top of the list

is this a behaviour we've lost at some point? To me it looks like we just show filters based on alphabetic order. Mind clarifying if this ticket is still valid?

comment:4 in reply to: ↑ 3 Changed 19 months ago by greiner

Replying to agiammarchi:

is this a behaviour we've lost at some point? To me it looks like we just show filters based on alphabetic order. Mind clarifying if this ticket is still valid?

We initialize filters in alphabetical order on page load. When you add a new filter we add it to the top of the list rather than inserting it accordingly (see options page spec).

comment:5 Changed 7 days ago by greiner

  • Resolution set to worksforme
  • Status changed from new to closed

Closing this ticket because it's unclear whether this expectation still holds up with the current state of the spec.

Note: See TracTickets for help on using tickets.