Opened 2 weeks ago

Closed 4 days ago

#5631 closed defect (fixed)

In more filters section filters that are disabled are being shown on first load

Reported by: saroyanm Assignee: saroyanm
Priority: P1 Milestone:
Module: User-Interface Keywords:
Cc: greiner, juliandoucette Blocked By:
Blocking: #5158 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29545663/

Description

Environment

Chrome v60

How to reproduce

  1. Run test server for Adblockplusui and/or navigate to github pages
  2. Open advanced tab Advanced tab
  3. Observe the "Adblock Warning Removal List" item
  4. Navigate to General tab
  5. Observe same item in "More filters" section

Observed behaviour

"Adblock Warning Removal List" is being disabled in the advanced tab and being shown on the General tab still.

Expected behaviour

"Adblock Warning Removal List" is not being shown in the general tab when it's disabled.

Change History (4)

comment:1 Changed 7 days ago by saroyanm

  • Owner set to saroyanm

comment:2 Changed 7 days ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 4 days ago by abpbot

A commit referencing this issue has landed:
Issue 5631 - do not show disabled filters in more section

comment:4 Changed 4 days ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.