Opened 2 years ago

Closed 22 months ago

#5632 closed change (fixed)

Use checkboxes for toggling acceptable ads and add new label

Reported by: saroyanm Assignee: saroyanm
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: greiner, juliandoucette Blocked By: #5869
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29578574/
https://codereview.adblockplus.org/29587711/

Description (last modified by saroyanm)

Background

After several design iterations we finally have a final version of the new options page (See #5158).
But the section of adding Acceptable Ads in general tab is misleading, because we mentioned "Block All ads" for the option which disables acceptable ads, but we need to communicate to the user that this option disables acceptable ads.

What to change

Implement new layout of managing Acceptable Ads as specified here using current style guide.

Change History (18)

comment:1 Changed 2 years ago by saroyanm

  • Description modified (diff)
  • Summary changed from New label next to the Privacy friendly acceptable ads is missing to New label next to the Privacy friendly acceptable ads and DNT link is missing

comment:2 Changed 2 years ago by saroyanm

  • Priority changed from P2 to P1

comment:3 Changed 2 years ago by saroyanm

  • Owner set to saroyanm

comment:4 Changed 2 years ago by saroyanm

  • Description modified (diff)

comment:5 Changed 2 years ago by saroyanm

  • Description modified (diff)
  • Summary changed from New label next to the Privacy friendly acceptable ads and DNT link is missing to New label next to the Privacy friendly acceptable ads is missing

Missing DNT link is being handled in #5701

comment:6 Changed 2 years ago by saroyanm

  • Priority changed from P1 to P2

This is not P1 anymore as the P1 part is removed from this ticket see comment above.

comment:7 Changed 2 years ago by saroyanm

  • Blocking 5158 removed

We decided during today meeting that this shouldn't be blocker for the initial release on dev builds.

comment:8 Changed 23 months ago by saroyanm

  • Description modified (diff)

I've updated this issue description to reflect the whole layout change that also includes the "new" label, because we already launched the section without "new" label.

comment:9 Changed 23 months ago by saroyanm

  • Description modified (diff)

comment:10 Changed 23 months ago by saroyanm

  • Summary changed from New label next to the Privacy friendly acceptable ads is missing to Use checkboxes for enabling acceptable ads and add new label

comment:11 Changed 23 months ago by saroyanm

  • Summary changed from Use checkboxes for enabling acceptable ads and add new label to Use checkboxes for toggling acceptable ads and add new label

comment:12 Changed 23 months ago by saroyanm

  • Description modified (diff)

comment:13 Changed 23 months ago by saroyanm

  • Blocked By 5869 added

comment:14 Changed 23 months ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:15 Changed 22 months ago by abpbot

A commit referencing this issue has landed:
Issue 5632 - Use checkboxes for toggling acceptable ads

comment:16 Changed 22 months ago by saroyanm

  • Review URL(s) modified (diff)

comment:17 Changed 22 months ago by abpbot

comment:18 Changed 22 months ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.