Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#5634 closed change (fixed)

Change the abp.org header into a navbar

Reported by: juliandoucette Assignee: juliandoucette
Priority: P2 Milestone: adblockplus.org 1.1.0
Module: Websites Keywords: goodfirstbug
Cc: wspee, ire Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):
  1. Remove search: https://codereview.adblockplus.org/29551727
  2. Remove locale flags: https://codereview.adblockplus.org/29551734/

3 & 4: Remove logo & refactor [width, colors]: https://codereview.adblockplus.org/29551738/

Description (last modified by juliandoucette)

Background

See adblockplus.org 2.x.

What to change

Change abp.org header into a red navbar as-seen in milestone desktop and mobile designs.

Notes

It makes sense to break this up into a few steps:

  1. Remove search
  2. Remove locale flags
  3. Replace logo
  4. Refactor width and colors

Also, because we don't have time:

  • Avoid adding new accessibility features
  • Avoid adding new strings

(I will refactor this later using a website-defaults navbar component after we have implemented websites code sharing.)

Change History (25)

comment:1 Changed 2 years ago by juliandoucette

  • Blocked By 5635 added

comment:2 Changed 2 years ago by juliandoucette

  • Blocking 5636 added

comment:3 Changed 2 years ago by juliandoucette

  • Blocked By 5635 removed

comment:4 Changed 2 years ago by juliandoucette

  • Cc wspee ire removed
  • Summary changed from Change the adblockplus.org header into a navbar to Change the abp.org header into a navbar

comment:5 Changed 2 years ago by juliandoucette

  • Blocking 5725 added

comment:6 Changed 2 years ago by juliandoucette

  • Priority changed from P3 to P2

comment:7 Changed 2 years ago by juliandoucette

  • Blocking 5725 removed

comment:8 Changed 2 years ago by juliandoucette

  • Milestone changed from adblockplus.org 2.1.0 to adblockplus.org 1.1.0

comment:9 Changed 2 years ago by juliandoucette

  • Owner set to juliandoucette

comment:10 Changed 2 years ago by juliandoucette

  • Owner juliandoucette deleted

comment:11 Changed 2 years ago by juliandoucette

  • Cc wspee ire added
  • Description modified (diff)
  • Owner set to juliandoucette

comment:12 Changed 2 years ago by juliandoucette

  • Description modified (diff)

comment:13 Changed 2 years ago by juliandoucette

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:14 Changed 2 years ago by juliandoucette

  • Review URL(s) modified (diff)

comment:15 Changed 2 years ago by juliandoucette

  • Description modified (diff)

comment:16 Changed 2 years ago by juliandoucette

  • Review URL(s) modified (diff)

comment:17 Changed 2 years ago by juliandoucette

  • Review URL(s) modified (diff)

comment:18 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5634 - Removed search from header

comment:19 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5634 - Backed out changeset 42c83a80689b

comment:22 Changed 2 years ago by juliandoucette

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:23 Changed 2 years ago by juliandoucette

  • Description modified (diff)

comment:24 Changed 2 years ago by juliandoucette

  • Blocking 5636 removed
Note: See TracTickets for help on using tickets.