Opened 2 years ago

Closed 2 years ago

#5644 closed defect (fixed)

upload.y doesn't upload binary diffs when used with a git repository

Reported by: kvas Assignee: kvas
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: tlucas, snoack, matze Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29539660/

Description

Environment

Linux or MacOS, git version 2.10.1.

How to reproduce

  • Create an empty git repository.
  • Create an initial commit.
  • Create a commit with a binary file (e.g. a PNG file).
  • Use upload.py to upload the second commit to a new review.
  • Got to Rietveld web UI and look at the raw patch.

Observed behaviour

Contents of the binary file are missing from the patch.

Expected behaviour

Contents of the binary file are present in the patch, similarly as if the patch was uploaded from a Mercurial repository.

Change History (3)

comment:1 Changed 2 years ago by kvas

  • Cc tlucas snoack matze added
  • Component changed from Unknown to Sitescripts
  • Owner set to kvas
  • Priority changed from Unknown to P3
  • Ready set

comment:2 Changed 2 years ago by kvas

  • Status changed from new to reviewing

comment:3 Changed 2 years ago by kvas

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.