Opened on 09/08/2017 at 11:25:27 AM

Closed on 10/24/2017 at 07:46:44 PM

#5644 closed defect (fixed)

upload.y doesn't upload binary diffs when used with a git repository

Reported by: kvas Assignee: kvas
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: tlucas, snoack, matze Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):



Linux or MacOS, git version 2.10.1.

How to reproduce

  • Create an empty git repository.
  • Create an initial commit.
  • Create a commit with a binary file (e.g. a PNG file).
  • Use to upload the second commit to a new review.
  • Got to Rietveld web UI and look at the raw patch.

Observed behaviour

Contents of the binary file are missing from the patch.

Expected behaviour

Contents of the binary file are present in the patch, similarly as if the patch was uploaded from a Mercurial repository.

Attachments (0)

Change History (3)

comment:1 Changed on 09/08/2017 at 04:47:05 PM by kvas

  • Cc tlucas snoack matze added
  • Component changed from Unknown to Sitescripts
  • Owner set to kvas
  • Priority changed from Unknown to P3
  • Ready set

comment:2 Changed on 09/08/2017 at 04:49:37 PM by kvas

  • Status changed from new to reviewing

comment:3 Changed on 10/24/2017 at 07:46:44 PM by kvas

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kvas.
Note: See TracTickets for help on using tickets.