Opened 2 years ago

Closed 22 months ago

#5651 closed change (fixed)

Set relative values for strong and small elements in website-defaults

Reported by: ire Assignee: juliandoucette
Priority: P3 Milestone:
Module: Websites Keywords: goodfirstbug
Cc: juliandoucette Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29588979

Description

Background

Currently in website-defaults, the weight of strong and size of small elements are set using absolute pixel values. This does not allow for properly styled nested elements.

What to change

Change the value of font-weight on strong,b to bolder (supported since CSS Level 1)

Change the value of font-size on small to a relative value (e.g. 80%)

Change History (5)

comment:1 Changed 2 years ago by juliandoucette

  • Priority changed from Unknown to P3

comment:2 Changed 22 months ago by juliandoucette

  • Owner set to juliandoucette

comment:3 Changed 22 months ago by juliandoucette

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 22 months ago by abpbot

A commit referencing this issue has landed:
Issue 5651 - Set relative values for strong and small

comment:5 Changed 22 months ago by juliandoucette

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.