Opened 2 years ago

Closed 22 months ago

#5655 closed change (fixed)

Create a rules file for Swift Lint

Reported by: CraftyDeano Assignee: CraftyDeano
Priority: Unknown Milestone:
Module: Adblock-Plus-for-iOS/macOS Keywords: lint
Cc: ashephard, dzhang Blocked By:
Blocking: Platform: iOS
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29558682/

Description (last modified by CraftyDeano)

Background

We will use Swift Lint to lint our swift files and ensure coding standards, however we first need to agree on a set of rules & configure a rules file inside the project.

What to change

  1. Agree on rules that should be applied
  2. Create & configure a configuration file for Swift Lint within the project.

Change History (5)

comment:1 Changed 2 years ago by CraftyDeano

Created a spreadsheet of the current rules in Swift Lint and invited Andy & Daniel to submit their preferences on what rules should be enabled/disabled. Once complete, we will discuss outcomes.

comment:2 Changed 2 years ago by CraftyDeano

  • Description modified (diff)

comment:3 Changed 2 years ago by dzhang

I’ve drafted my answers for the swiftlint rules but I'll review them again later. I have some ideas for custom rules that I’d like to try that I'll add here.

comment:4 Changed 23 months ago by CraftyDeano

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 22 months ago by CraftyDeano

  • Resolution set to fixed
  • Status changed from reviewing to closed

Landed

Note: See TracTickets for help on using tickets.