Opened 3 years ago

Closed 11 months ago

#5661 closed change (rejected)

[emscripten] Move impl of Subscription serialization from Subscription classes

Reported by: sergz Assignee: sergz
Priority: P3 Milestone:
Module: Core Keywords: closed-in-favor-of-gitlab
Cc: oleksandr Blocked By:
Blocking: #4122 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by sergz)

It's almost duplication of #5138.

Background

The Subscription classes should not be aware how they are used, in particular how they are serialized and parsed and what format is used. In addition, parsing and serializing code would share some common parts which are likely not related to Subscription classes.

What to change

  • create PatternsIniSerializer class which writes headers (e.g. version=5) and can serialize Subscription classes in INI format.
  • for the sake of simplicity keep Serialize member functions but don't expose them to JS and they should merely create a \n concatenated property=value strings. SerializeFilters should be migrated into PatternsIniSerializer and Subscription class should expose the non-modifiable container of Filters, e.g. const Subscription::Filters&.

Change History (6)

comment:1 Changed 3 years ago by sergz

  • Description modified (diff)

comment:2 Changed 3 years ago by sergz

  • Owner set to sergz

comment:3 Changed 3 years ago by oleksandr

  • Cc oleksandr added

comment:4 Changed 3 years ago by trev

  • Blocking 5137 removed

comment:5 Changed 3 years ago by fhd

  • Cc trev removed

comment:6 Changed 11 months ago by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from new to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the ​new issue tracker.

Note: See TracTickets for help on using tickets.