Opened 2 years ago

Last modified 20 months ago

#5661 new change

[emscripten] Move impl of Subscription serialization from Subscription classes

Reported by: sergz Assignee: sergz
Priority: P3 Milestone:
Module: Core Keywords:
Cc: oleksandr Blocked By:
Blocking: #4122 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by sergz)

It's almost duplication of #5138.


The Subscription classes should not be aware how they are used, in particular how they are serialized and parsed and what format is used. In addition, parsing and serializing code would share some common parts which are likely not related to Subscription classes.

What to change

  • create PatternsIniSerializer class which writes headers (e.g. version=5) and can serialize Subscription classes in INI format.
  • for the sake of simplicity keep Serialize member functions but don't expose them to JS and they should merely create a \n concatenated property=value strings. SerializeFilters should be migrated into PatternsIniSerializer and Subscription class should expose the non-modifiable container of Filters, e.g. const Subscription::Filters&.

Change History (5)

comment:1 Changed 2 years ago by sergz

  • Description modified (diff)

comment:2 Changed 2 years ago by sergz

  • Owner set to sergz

comment:3 Changed 23 months ago by oleksandr

  • Cc oleksandr added

comment:4 Changed 23 months ago by trev

  • Blocking 5137 removed

comment:5 Changed 20 months ago by fhd

  • Cc trev removed
Note: See TracTickets for help on using tickets.