Opened on 09/12/2017 at 02:12:17 PM

Closed on 08/29/2019 at 05:43:52 PM

#5661 closed change (rejected)

[emscripten] Move impl of Subscription serialization from Subscription classes

Reported by: sergz Assignee: sergz
Priority: P3 Milestone:
Module: Core Keywords: closed-in-favor-of-gitlab
Cc: oleksandr Blocked By:
Blocking: #4122 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by sergz)

It's almost duplication of #5138.


The Subscription classes should not be aware how they are used, in particular how they are serialized and parsed and what format is used. In addition, parsing and serializing code would share some common parts which are likely not related to Subscription classes.

What to change

  • create PatternsIniSerializer class which writes headers (e.g. version=5) and can serialize Subscription classes in INI format.
  • for the sake of simplicity keep Serialize member functions but don't expose them to JS and they should merely create a \n concatenated property=value strings. SerializeFilters should be migrated into PatternsIniSerializer and Subscription class should expose the non-modifiable container of Filters, e.g. const Subscription::Filters&.

Attachments (0)

Change History (6)

comment:1 Changed on 09/13/2017 at 05:21:31 PM by sergz

  • Description modified (diff)

comment:2 Changed on 09/13/2017 at 06:55:41 PM by sergz

  • Owner set to sergz

comment:3 Changed on 10/11/2017 at 01:04:14 PM by oleksandr

  • Cc oleksandr added

comment:4 Changed on 10/12/2017 at 10:23:29 AM by trev

  • Blocking 5137 removed

comment:5 Changed on 12/21/2017 at 11:29:03 AM by fhd

  • Cc trev removed

comment:6 Changed on 08/29/2019 at 05:43:52 PM by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from new to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sergz.
Note: See TracTickets for help on using tickets.