Opened on 09/12/2017 at 02:38:20 PM

Closed on 09/22/2017 at 01:18:48 PM

Last modified on 09/24/2017 at 06:03:47 PM

#5664 closed change (fixed)

[emscripten] Change `assert` macro to accept a single parameter.

Reported by: sergz Assignee: hfiguiere
Priority: P4 Milestone:
Module: Core Keywords:
Cc: trev Blocked By:
Blocking: #4122 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):



assert is an expected standard macro, therefore when one includes standard headers after our definition of the macro the code cannot be compiled.

What to change

  • change it to accept only a single parameter
  • consider adding some assert2 accepting a description as the second argument or some analog.

Attachments (0)

Change History (5)

comment:1 Changed on 09/19/2017 at 07:23:57 PM by hfiguiere

  • Owner set to hfiguiere
  • Review URL(s) modified (diff)

comment:2 Changed on 09/19/2017 at 07:24:04 PM by hfiguiere

  • Status changed from new to reviewing

comment:3 Changed on 09/22/2017 at 01:17:50 PM by abpbot

A commit referencing this issue has landed:
Issue 5664 - assert now accept one parameter.

comment:4 Changed on 09/22/2017 at 01:18:48 PM by hfiguiere

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed on 09/24/2017 at 06:03:47 PM by trev

  • Priority changed from P5 to P4
  • Ready set

For reference, priority is usually set by module owner or peers. Also, P5 is used for issues that shouldn't be worked on.

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from hfiguiere.
Note: See TracTickets for help on using tickets.