#5667 closed change (fixed)

Add missing action extension icons & clean up file names

Reported by: dzhang Assignee: ashephard
Priority: Unknown Milestone: Adblock-Plus-for-iOS-next
Module: Adblock-Plus-for-iOS/macOS Keywords:
Cc: mario, tiago, ashephard, CraftyDeano, martin Blocked By: #3184
Blocking: Platform: iOS
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29544590/

Description (last modified by dzhang)

Background

The icon set for the Safari action extension requires a similiar treatment of adding missing icons and setting unique names as #5595.

The Xcode app icon template is a bit confusing and misleading. It has slots for every possible icon and it's easy to think they should all be filled in.

For extensions, I've gained a new understanding after doing more research into what icons are actually used.

I believe the following list is correct for the extension and we shouldn't add additional icons as they will consume storage.

abp-app-ext-icon-60-iphone@2x.png
abp-app-ext-icon-60-iphone@3x.png
abp-app-ext-icon-76-iphone@2x.png
abp-app-ext-icon-83,5-ipad@2x.png

The other icons are used for spotlight, notifications, settings and the app store. None of those apply to the action extension.

The action extension icon is meant to be a transparent, monochrome version of the app icon according to Apple's App Extension guide.

Therefore, I recommend we reduce the included assets for the action extension to include only the app icons for iPhone, iPad and iPad Pro.

What to change

Add required icons while removing those that are not required. Give the icons unique names.

Please make names consistent with #5595.

Attachments (1)

ABP-Safari-Extension-Icon.zip (64.2 KB) - added by martin 21 months ago.
Updated the ticket with the new icon along with all its sizes. Let me know if anything needs fixing.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 21 months ago by dzhang

  • Summary changed from Add missing action extension icons to & clean up file names to Add missing action extension icons & clean up file names

Changed 21 months ago by martin

Updated the ticket with the new icon along with all its sizes. Let me know if anything needs fixing.

comment:2 Changed 21 months ago by ashephard

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 21 months ago by ashephard

  • Owner set to ashephard

comment:4 Changed 21 months ago by ashephard

  • Review URL(s) modified (diff)

comment:5 Changed 21 months ago by dzhang

  • Description modified (diff)

comment:6 Changed 21 months ago by dzhang

  • Description modified (diff)

comment:7 Changed 21 months ago by dzhang

  • Type changed from defect to change

comment:8 Changed 21 months ago by ashephard

Updated the codereview with the necessary changes.

comment:9 Changed 21 months ago by ashephard

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.